shortcuts/im/helpers.go (1)

571-594: ⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Duration parsing will fail for absolute audio/video paths.

parseMediaDuration calls runtime.FileIO().Stat() and runtime.FileIO().Open() (lines 575, 579), which reject absolute paths outside the working directory. For absolute audio/video files, duration parsing will fail silently (returning ""), causing uploads to succeed but omit the duration field.

🔧 Suggested fix

Refactor parseMediaDuration to use the dual-mode helpers:

 func parseMediaDuration(runtime *common.RuntimeContext, filePath, fileType string) string {
 	if fileType != "opus" && fileType != "mp4" {
 		return ""
 	}
-	info, err := runtime.FileIO().Stat(filePath)
+	info, err := statMediaFile(runtime, filePath)
 	if err != nil || info.Size() == 0 {
 		return ""
 	}
-	f, err := runtime.FileIO().Open(filePath)
+	f, err := openMediaFile(runtime, filePath)
 	if err != nil {
 		return ""
 	}
+	defer f.Close()

 	var ms int64
 	if fileType == "opus" {
-		ms = readOggDuration(f, info.Size())
+		ms = readOggDuration(f.(fileio.File), info.Size())
 	} else {
-		ms = readMp4Duration(f, info.Size())
+		ms = readMp4Duration(f.(fileio.File), info.Size())
 	}
 	if ms <= 0 {
 		return ""
 	}
 	return strconv.FormatInt(ms, 10)
 }

Note: You'll need to update readOggDuration and readMp4Duration to accept io.ReaderAt instead of fileio.File, or add type assertions as shown.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@shortcuts/im/helpers.go` around lines 571 - 594, parseMediaDuration currently
fails for absolute paths because it uses runtime.FileIO().Stat() and Open()
which reject absolute locations; refactor parseMediaDuration to use the
dual-mode file helpers (open a reader that supports both filesystem and external
absolute URLs) instead of directly calling runtime.FileIO().Stat/Open, and
update readOggDuration and readMp4Duration to accept a generic io.ReaderAt (or
perform a safe type assertion on the returned reader) so you can pass the reader
returned by the dual-mode helper; ensure ms calculation and error handling
remain the same in parseMediaDuration and return the formatted ms when >0.